Re: [PATCH] m68k: merge the mmu and non-mmu versions of ptrace.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Greg,

On Tue, Feb 21, 2012 at 07:31, Greg Ungerer <gerg@xxxxxxxxxxxx> wrote:
On 19/02/12 20:12, Geert Uytterhoeven wrote:
On Tue, Feb 7, 2012 at 04:25,<gerg@xxxxxxxxxxxx>  wrote:
--- a/arch/m68k/kernel/ptrace_mm.c
+++ b/arch/m68k/kernel/ptrace.c
@@ -277,7 +287,6 @@ asmlinkage void syscall_trace(void)
       }
}

-#ifdef CONFIG_COLDFIRE
asmlinkage int syscall_trace_enter(void)
{
       int ret = 0;
@@ -292,4 +301,3 @@ asmlinkage void syscall_trace_leave(void)
       if (test_thread_flag(TIF_SYSCALL_TRACE))
               tracehook_report_syscall_exit(task_pt_regs(current), 0);
}
-#endif /* CONFIG_COLDFIRE */


Why have you dropped the #ifdef?

Purely to have less "#ifdef"s in the code.

IC.

Does bloat the code a little, would you prefer I leave the #ifdef there?

Yes, it serves as a reminder to add syscall trace support.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Video for Linux]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux