Re: [PATCH 33/35] m68k: do not use m68k startup or interrupt code for ColdFire CPU's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Greg,

On Wed, Dec 28, 2011 at 01:22, Greg Ungerer <gerg@xxxxxxxxxxxx> wrote:
On 28/12/11 04:30, Geert Uytterhoeven wrote:
On Tue, Dec 27, 2011 at 13:24, Greg Ungerer<gerg@xxxxxxxxxxxx>  wrote:
áextra-$(CONFIG_MMU) á á á á á á:= head.o
áextra-$(CONFIG_SUN3) á := sun3-head.o
+extra-$(CONFIG_COLDFIRE) á á á :=

Why do you need the line above?

That is to avoid using a "#ifndef CONFIG_COLDFIRE" around these.
This entry clears out extra-y for the case when both CONFIG_MMU
and CONFIG_COLDFIRE are set.

Ooh, that's ugly, and easily overlooked (I missed it).
So you don't want head.o for Coldfire. What about

extra-$(CONFIG_MMU_MOTOROLA) := head.o
extra-$(CONFIG_SUN3)   := sun3-head.o

?

But since head.o is not really about MMU or not, but about the machine,
perhaps it should be explicitly written as

extra-$(CONFIG_AMIGA) := head.o
extra-$(CONFIG_ATARI) := head.o
...
extra-$(CONFIG_SUN3X) := head.o


I am happy to do it either way. The second option here will need a
longer list. I count 8 machines that use head.o (assuming VME is a
single machine type) and 1 that uses sun3-head.o. At least the first
option above just has the 2 lines.

What is your preference?

The latter, as people are experimenting with MMU-less machines now.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Video for Linux]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux