Re: regmap: Separate regmap dev initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/18/2014 01:59 PM, Dan Carpenter wrote:
> On Tue, Feb 18, 2014 at 01:33:30PM +0100, Michal Simek wrote:
>> Hi Dan,
>>
>> On 02/18/2014 01:24 PM, Dan Carpenter wrote:
>>> Hello Michal Simek,
>>>
>>> The patch 6cfec04bcc05: "regmap: Separate regmap dev initialization"
>>> from Feb 10, 2014, leads to the following static checker warning:
>>>
>>> 	drivers/base/regmap/regmap.c:765 regmap_init()
>>> 	warn: add curly braces?
>>>
>>> drivers/base/regmap/regmap.c
>>>    759          ret = regcache_init(map, config);
>>>    760          if (ret != 0)
>>>    761                  goto err_range;
>>>    762  
>>>    763          if (dev)
>>>    764                  ret = regmap_attach_dev(dev, map, config);
>>>    765                  if (ret != 0)
>>>    766                          goto err_regcache;
>>>
>>> Please add curly braces or adjust the indenting to not confuse the
>>> static checkers.
>>
>> I am aware about this. Mark has already applied RFC to any his branch
>> :-(. I can send v2 but it is up to Mark if he wants to fix it or not.
>>
> 
> Oh, crap.  Sorry, I reported this twice.  I didn't mean to do that.
> 
> I normally grep my outbox to avoid this but I had a typo in my grep this
> time.

I didn't expect that Mark apply RFC too but it was probably good enough
and we can fix this by one more patch. Feel free to submit it
against
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git tags/nodev

Thanks,
Michal


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux