Re: qlcnic: Enhance logic to calculate msix vectors.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jan 28, 2014, at 1:04 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> Hello Himanshu Madhani,
> 
> The patch cb9327d567be: "qlcnic: Enhance logic to calculate msix
> vectors." from Jan 23, 2014, leads to the following
> static checker warning:
> 
> 	drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:678
> 	qlcnic_setup_tss_rss_intr() info: ignoring unreachable code."
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
>   669                  if (qlcnic_83xx_check(adapter))
>   670                          num_msix += 1;
>   671  
>   672                  netdev_info(adapter->netdev,
>   673                              "Restoring %d Tx, %d SDS rings for total %d vectors.\n",
>   674                              adapter->drv_tx_rings, adapter->drv_sds_rings,
>   675                              num_msix);
>   676                  goto restore;
>   677  
>   678                  err = -EIO;
>                        ^^^^^^^^^^
> Should this be in front of the goto?
> 

This needs to be removed. We will send a patch to fix this and add you as reporter of this problem. 

>   679          }
>   680  
>   681          return err;
>   682  }
> 
> 
> regards,
> dan carpenter
> 

Thanks,
-Himanshu--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux