Re: [patch] Input: wacom: NULL dereference on allocation failure

[Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>]

On Wed, Apr 04, 2012 at 02:19:38PM +0300, Dan Carpenter wrote:
> If the "wac_i2c" alloction fails, then it leads to a NULL dereference.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Doh! I'll fold it up into original...

Thanks Dan!

> 
> diff --git a/drivers/input/touchscreen/wacom_i2c.c b/drivers/input/touchscreen/wacom_i2c.c
> index b29f064..b8ca4a6 100644
> --- a/drivers/input/touchscreen/wacom_i2c.c
> +++ b/drivers/input/touchscreen/wacom_i2c.c
> @@ -252,7 +252,7 @@ static int __devinit wacom_i2c_probe(struct i2c_client *client,
>  err_free_irq:
>  	free_irq(client->irq, wac_i2c);
>  err_free_mem:
> -	input_free_device(wac_i2c->input);
> +	input_free_device(input);
>  	kfree(wac_i2c);
>  
>  	return error;

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html