RE: [patch] hv: fix return type of hv_post_message()

[KY Srinivasan <kys@xxxxxxxxxxxxx>]

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@xxxxxxxxxx]
> Sent: Wednesday, March 28, 2012 2:58 AM
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@xxxxxxxxxxxxxxxxxxxxxx; kernel-
> janitors@xxxxxxxxxxxxxxx
> Subject: [patch] hv: fix return type of hv_post_message()
> 
> This function returns negative error codes, but because the type is u16
> they get truncated into positive numbers.  It doesn't look like the
> callers care, but we should fix it anyway as a cleanup.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks Dan.

Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> 
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 699f0d8..b9426a6 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -495,7 +495,7 @@ extern int hv_init(void);
> 
>  extern void hv_cleanup(void);
> 
> -extern u16 hv_post_message(union hv_connection_id connection_id,
> +extern int hv_post_message(union hv_connection_id connection_id,
>  			 enum hv_message_type message_type,
>  			 void *payload, size_t payload_size);
> 
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index 15956bd..86f8885 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -252,7 +252,7 @@ void hv_cleanup(void)
>   *
>   * This involves a hypercall.
>   */
> -u16 hv_post_message(union hv_connection_id connection_id,
> +int hv_post_message(union hv_connection_id connection_id,
>  		  enum hv_message_type message_type,
>  		  void *payload, size_t payload_size)
>  {


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html