Re: [patch] nfsd4: memory corruption in numeric_name_to_id()

["J. Bruce Fields" <bfields@xxxxxxxxxxxx>]

On Wed, Mar 28, 2012 at 01:44:59PM +0300, Dan Carpenter wrote:
> "id" is type is a uid_t (32 bits) but on 64 bit systems strict_strtoul()
> modifies 64 bits of data.  We should use kstrtouint() instead.

Whoops--thanks, applied!

--b.

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
> index 69ca9c5..322d11c 100644
> --- a/fs/nfsd/nfs4idmap.c
> +++ b/fs/nfsd/nfs4idmap.c
> @@ -581,7 +581,7 @@ numeric_name_to_id(struct svc_rqst *rqstp, int type, const char *name, u32 namel
>  	/* Just to make sure it's null-terminated: */
>  	memcpy(buf, name, namelen);
>  	buf[namelen] = '\0';
> -	ret = strict_strtoul(name, 10, (unsigned long *)id);
> +	ret = kstrtouint(name, 10, id);
>  	return ret == 0;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html