Re: [patch] edac i5000: fix pointer math in i5000_get_mc_regs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Am 02.03.2012 07:54, schrieb Dan Carpenter:
> "pvt->ambase" is a u64 datatype.  The intent here is to fill the first
> half in the first call to pci_read_config_dword() and the other half in
> the second.  Unfortunately the pointer math is wrong so we set the wrong
> data.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> I don't have the hardware to test this.  Please review carefully.
> 
> diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
> index 4dc3ac2..fcdc4ab 100644
> --- a/drivers/edac/i5000_edac.c
> +++ b/drivers/edac/i5000_edac.c
> @@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
>  	pci_read_config_dword(pvt->system_address, AMBASE,
>  			(u32 *) & pvt->ambase);
>  	pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
> -			((u32 *) & pvt->ambase) + sizeof(u32));
> +			(u32 *)((char *) &pvt->ambase + sizeof(u32)));
>  
>  	maxdimmperch = pvt->maxdimmperch;
>  	maxch = pvt->maxch;

i think this is hard to understand. personally i would prefer a union or other
more obvious solutions. my suggestion would be to get rid of this.

u32 bottom,top;
 	pci_read_config_dword(pvt->system_address, AMBASE,
  			&bottom);
	pci_read_config_dword(pvt->system_address, AMBASE+ sizeof(u32),
  			&top);
	maxdimmperch=(u64)top<<32|bottom;
	
you can find this pattern in other parts of the kernel also.

hope that helps
re,
 wh


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]     [Free Dating]

Add to Google Powered by Linux