Re: [PATCH 2/2] merge_config.sh: Add option to display redundant configs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Fri, Mar 23, 2012 at 12:52:08PM -0700, John Stultz wrote:
> Provide a -r option to display when fragments contain redundant
> options. This is really useful when breaking apart a config into
> fragments, as well as cleaning up older fragments.
> 
> v2:
> Now w/ spelling fixes! Thanks Darren!
> 
> CC: Michal Marek <mmarek@xxxxxxx>
> CC: Bruce.Ashfield@xxxxxxxxxxxxx
> CC: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>

Applied.


> +WARNREDUN=false
>  
>  while true; do
>  	case $1 in
> @@ -52,6 +54,11 @@ while true; do
>  		usage
>  		exit
>  		;;
> +	"-r")
> +		WARNREDUN=true
> +		shift
> +		continue
> +		;;
>  	*)
>  		break
>  		;;
> @@ -79,6 +86,8 @@ for MERGE_FILE in $MERGE_LIST ; do
>  			echo Previous  value: $PREV_VAL
>  			echo New value:       $NEW_VAL
>  			echo
> +			elif [ "$WARNREDUN" = "true" ]; then

If you are using true/false for flag variables, then you can simply say

			elif $WARNREDUN; then

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux