Re: [PATCH RFC] try to create KBUILD_OUTPUT automatically |
|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH RFC] try to create KBUILD_OUTPUT automatically
- From: Michal Marek <mmarek@xxxxxxx>
- Date: Sun, 11 Dec 2011 21:34:02 +0100
- Cc: Linux Kbuild Mailing List <linux-kbuild@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
- In-reply-to: <alpine.LNX.2.00.1110221049460.59156@linux>
- References: <alpine.LNX.2.00.1110221049460.59156@linux>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111105 Thunderbird/8.0
On 22.10.2011 17:12, Peter Foley wrote:
> This patch makes it possible to execute make O=work instead of
> mkdir work
> make O=work
>
> Signed-off-by: Peter Foley <pefoley2@xxxxxxxxxxx>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 2652089..a4769ac 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -117,7 +117,7 @@ ifneq ($(KBUILD_OUTPUT),)
> # Invoke a second make in the output directory, passing relevant variables
> # check that the output directory actually exists
> saved-output := $(KBUILD_OUTPUT)
> -KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
> +KBUILD_OUTPUT := $(shell mkdir -p $(KBUILD_OUTPUT) && cd $(KBUILD_OUTPUT) && /bin/pwd)
> $(if $(KBUILD_OUTPUT),, \
> $(error output directory "$(saved-output)" does not exist))
I think it's a good idea, but please also change the comment and error
message. The command will now only fail if the directory cannot be
created, not if it does not exist.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Devel]
[Linux Media]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]