Custom Search

[PATCH v3 0/4] Cypress PS/2 Trackpad driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

This driver, submitted on behalf of Cypress Semiconductor Corporation and
additional contributors, provides support for the Cypress PS/2 Trackpad.

This [PATCH v3] version differs from my previous submitted version[1]:

  Patch #1 (cmdbuf to 8 bytes) and #3 (link in driver) are unchanged.

  Patch #2 (main driver), as recommended by Henrik Rydberg[2]:
  - use input_mt_assign_slots; drop cypress_cal_finger_id.
  - enable 2-finger-only SEMI_MT; drop cypress_simulate_fingers.
  - various code clean-ups.

  Henrik, does patch #2 appear to properly use assign_slots and SEMI_MT as
  you intended?  This SEMI_MT method does work (with 2 finger support only),
  but I'm not clear why we wouldn't want to handle >2 fingers also, so ...

  Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers
  (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again.

  If that functionality (support for >2 fingers) can be acheived in some
  better way, please advise.

Remaining known problems (assistance or advice appreciated):

  - Multitouch >2 fingers does not work after rmmod/insmod, and stops
    working after suspend/resume.  Restarting X fixes it in both cases.

  - cypress_reconnect() never actually works, so I disabled it; just let
    psmouse re-init the driver instead, which works and is what was ending
    up happenning anyway.

 -Kamal Mostafa <kamal@xxxxxxxxxxxxx>

[0] PATCH v1:
[1] PATCH v2:
[2] Henrik's review:

Cypress Semiconductor Corporation (2):
  input: Cypress PS/2 Trackpad psmouse driver
  input: Cypress PS/2 Trackpad link into psmouse-base

Kamal Mostafa (2):
  input: increase struct ps2dev cmdbuf[] to 8 bytes
  input: Cypress PS/2 Trackpad simulated multitouch

 drivers/input/mouse/Kconfig        |   10 +
 drivers/input/mouse/Makefile       |    1 +
 drivers/input/mouse/cypress_ps2.c  |  846 ++++++++++++++++++++++++++++++++++++
 drivers/input/mouse/cypress_ps2.h  |  231 ++++++++++
 drivers/input/mouse/psmouse-base.c |   32 ++
 drivers/input/mouse/psmouse.h      |    1 +
 include/linux/libps2.h             |    2 +-
 7 files changed, 1122 insertions(+), 1 deletion(-)
 create mode 100644 drivers/input/mouse/cypress_ps2.c
 create mode 100644 drivers/input/mouse/cypress_ps2.h


To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux