Re: Why Cypress does not upstream its trackpad driver?
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Wed, Nov 07, 2012 at 10:45:31PM -0500, Ben Gamari wrote: > David Solda <dso@xxxxxxxxxxx> writes: > > > Dmitry, all, > > > > To clarify my comment. Our protocol utilizes 8 bytes which are needed > > in our driver. In order for the Linux system to accept 8 bytes of > > data, the Linux psmouse system driver is required to be modified. > > Without this modification, the driver that you are referring to will > > not work correctly. The psmouse system driver change that would be > > required is the item that would be rejected. > > > > I appreciate your comments and of course, if the driver could be > > upstreamed, it would (we already have I2C drivers updstreamed for > > Chrome systems), but there is a difference here. > > > > I will again look into the possibility of what you are requesting, > > however, the changes are extremely low if not zero that it will be > > accepted. > > > You are speaking to the people who ultimately decide whether your change > will be accepted or not. Currently there is no way anyone could know > whether the desired change is acceptable as no patch has been > submitted. > > Send a patch with the (minimal, well-organized) needed changes and the > matter can be discussed from there. If the changes are sane and well > justified, then there's little reason why they can't be accepted. OK, so I looked at the psmouse changes briefly and indeed some of them will not be accepted, because they are really ... weird. Surely if your device produces command responses in excess of 6 bytes that is currently the limit in libps2 module the easiest way would be increasing the buffer in struct ps2dev. The rest of psnouse-base changes are OK (and indeed because protocol types are exported to userspace and thus form ABI new definitions has to go to the end of the list); the driver itself needs bunch cleanups. Henrik needs to see it as well. It looks like you are trying to implement both relative and absolute modes of operation, but we only want absolute as it provides best experience. Please post the patches and we'll go form there. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html