Custom Search

Re: [PATCH] HID: hid-input: default HID_BATTERY_STRENGTH to no

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sun, 22 Apr 2012, Geert Uytterhoeven wrote:

> >> > Matthew suggested that additional kernel patches were required to add a
> >> > scope parameter so upower could understand that the battery is powering
> >> > a device and not the system.
> >> >
> >> > Also, when did it become OK to force-enable a new feature that is
> >> > _known_ to not work properly on recent userspace?  That makes no sense
> >> > to me.
> >>
> >> I agree. It's a great feature, but it shouldn't be default y if
> >> userspace isn't ready for it yet.
> >
> > Fully agreed, the 'default y' part escaped my attention. I will be
> > applying the patch and pushing out to Linus.
> >
> > I even wonder whether we shouldn't put a warning into the Kconfig entry,
> > explaining the consequences of having userspace not ready for the feature.
> 
> I saw it move from HID_BATTERY_STRENGTH=y to "# HID_BATTERY_STRENGTH
> is not set" in my max-all build.

Good point, thanks Geert. I will fix that up.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux