Re: [PATCH 2/4 branch usrmove] Add job control support to emergency shell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 26, 2011 at 10:06 AM, Dave Young <dyoung@xxxxxxxxxx> wrote:
> On 12/25/2011 07:59 PM, Cong Wang wrote:
>
>> On Fri, 23 Dec 2011 at 08:04 GMT, Dave Young <dyoung@xxxxxxxxxx> wrote:
>>> Option --ctty will optionally add setsid binary to dracut's image.
>>>
>>> During runtime, if rd.ctty is set and is a character device,
>>> emergency shells will be spawned with job control.
>>>
>>> in case no ctty was provided, shell was spawned without caring about
>>> /dev/console. Also, the ctty is more opportunistic. If the image was
>>> generated with --ctty, we will fallback to /dev/tty1 if rc.ctty is
>>> invalid or missing. Otherwise we spawn standard shell on /dev/console
>>>
>>> Signed-off-by: Michal Soltys <soltys@xxxxxxxx>
>>> Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
>>
>> IIRC, Michal is the author of this patch? If so, you need to
>> add "From:" in the beginning of this patch...
>
>
> It does not apply on the usrmove branch, I refreshed it based on this
> branch, so maybe add sighed-off-by of Michal is ok. Michal? any suggestion?

I think the correct way to handle this is:

1. Add From: Michal Soltys <soltys@xxxxxxxx>
2. Add S-o-b: Signed-off-by: Michal Soltys <soltys@xxxxxxxx>
3. Add your S-o-b: Signed-off-by: Dave Young <dyoung@xxxxxxxxxx>
4. Add one more line: [dyoung@xxxxxxxxxx: Rebased to usrmove branch]

At least this is what Andrew Morton did for linux kernel patches in mmotm.
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux