Re: [PATCH 09/14] staging:iio:buffers switch select kconfig elements to depends.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 4/25/2012 10:02 AM, Lars-Peter Clausen wrote:
On 04/22/2012 02:13 PM, Jonathan Cameron wrote:
As we are moving the IIO core out of staging, we need to
stop drivers in staging controlling whether elements of the
core are built.

Signed-off-by: Jonathan Cameron<jic23@xxxxxxxxxx>
---
  drivers/staging/iio/Kconfig |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index fe15867..e644508 100644
--- a/drivers/staging/iio/Kconfig
+++ b/drivers/staging/iio/Kconfig
@@ -28,7 +28,7 @@ config IIO_BUFFER
  if IIO_BUFFER

  config IIO_SW_RING
-       select IIO_TRIGGER
+        depends on IIO_TRIGGER
  	tristate "Industrial I/O lock free software ring"
  	help
  	  Example software ring buffer implementation.  The design aim
@@ -37,7 +37,7 @@ config IIO_SW_RING
  	  in interrupt context.

  config IIO_KFIFO_BUF
-	select IIO_TRIGGER
+	depends on IIO_TRIGGER
  	tristate "Industrial I/O buffering based on kfifo"
  	help
  	  A simple fifo based on kfifo.  Use this if you want a fifo

Is there actually anything in the code which gets enabled by these config
symbols that depends on IIO_TRIGGER?
Not that I can think of.. Would imagine they snuck in to prevent a build error at somepoint.
Took the view we can fix this up later as I've dropped all these patches.

- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux