Re: [PATCH] staging: iio: add lsm303dlh magnetometer driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Srinidhi Kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx> wrote:

>On Mon, Apr 09, 2012 at 22:51:45 +0200, Jonathan Cameron wrote:
>> On 04/09/2012 12:34 PM, Srinidhi KASAGAR wrote:
>> > Add support for lsm303dlh magnetometer device.
>> >
>> > Signed-off-by: srinidhi kasagar <srinidhi.kasagar@xxxxxxxxxxxxxx>
>> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>> Hi Srinidhi,
>> 
>> Basically a sound driver with a few easy bits to fix.
>> 
>> Few nitpicks and the error paths in probe need another look.
>> 
>Hi Jonathan,
>
>[...]
>
>> 
>> We have the old question of _range attributes as well and their
>> interaction with scale.  I've always been dubious about these,
>> mainly because it's not entirely obvious how to format the
>> weirder general cases.  Do you have a pressing need for range
>> or could it just be dropped in favour of allowing write for the
>> scale parameter? If nothing else, scale is available for inkernel
>> users and range isn't.
>If I need to drop range in favor of allowing write access for scale
>as you mentioned above, do you mean to implement _write_raw with
>IIO_CHAN_INFO_CALIBSCALE abi? Does it mean that user should be able
>to pass the scale factors so that driver interprets it to the
>corresponding range? 
>
>Srinidhi
Yes.   Scale should allow userspace to convert to the SI unit as well for any raw channels.  Range only does that if we also know the values the raw adc count can take.  
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux