Re: [PATCH] ipr: qc_fill_rtf() method should not store alternate status register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 01, 2013 at 02:37:00AM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/31/2013 04:46 PM, Brian King wrote:
> 
> >
> >>The 'ctl' field of  the 'struct ata_taskfile' is not really dual purpose, i.e.
> >>it is not intended  for storing the alternate status register (which is mapped
> >>at the same address in the legacy IDE controllers) in the qc_fill_rtf() method.
> >>No other 'libata' driver except 'drivers/scsi/ipr.c' stores the alternate status
> >>register's value in the 'ctl' field of 'qc->result_tf', hence this driver should
> >>not do this as well...
> >>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> >Acked-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>
> >
> 
>     Tejun, I would prefer that this patch be merged thru the libata tree
> as my future cleanup patches depend on it.

Applied to libata/for-3.11 w/ Brian's ack added.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux