- To: viresh kumar <viresh.linux@xxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, spear-devel@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, mturquette@xxxxxxxxxx, sshtylyov@xxxxxxxxxx, jgarzik@xxxxxxxxxx, linux@xxxxxxxxxxxxxxxx, linux-ide@xxxxxxxxxxxxxxx
- Subject: Re: [PATCH V3 07/12] ata/sata_mv: Remove conditional compilation of clk code
- From: viresh kumar <viresh.linux@xxxxxxxxx>
- Date: Tue, 24 Apr 2012 22:35:26 +0530
- In-reply-to: <20120424142939.GG24089@lunn.ch>
- List-id: <linux-ide.vger.kernel.org>
On 4/24/12, Andrew Lunn <andrew@xxxxxxx> wrote:
> static int __clk_enable(struct clk *clk)
> {
> int ret = 0;
>
> if (!clk)
> return 0;
>
> if (WARN_ON(clk->prepare_count == 0))
> return -ESHUTDOWN;
>
> this should actually be clk_prepare_enable(). Did you see my
> patches adding generic clk framework support for Orion. I fixed
> this as part of that patch set.
Sorry for missing it earlier. Ya i know it must be clk_prepare_enable(),
but it wasn't motive of my patchset.
Sorry, i haven't gone through your patches for Orion.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Filesystems]
[Linux SCSI]
[Linux RAID]
[Git]
[Kernel Newbies]
[Linux Newbie]
[Share Photos]
[Security]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]