- To: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code
- From: Viresh Kumar <viresh.kumar@xxxxxx>
- Date: Tue, 24 Apr 2012 13:28:20 +0530
- Cc: Andrew Lunn <andrew@xxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "sshtylyov@xxxxxxxxxx" <sshtylyov@xxxxxxxxxx>, spear-devel <spear-devel@xxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-ide@xxxxxxxxxxxxxxx" <linux-ide@xxxxxxxxxxxxxxx>, "viresh.linux@xxxxxxxxx" <viresh.linux@xxxxxxxxx>, "mturquette@xxxxxxxxxx" <mturquette@xxxxxxxxxx>, "jgarzik@xxxxxxxxxx" <jgarzik@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20120424074202.GO24211@n2100.arm.linux.org.uk>
- List-id: <linux-ide.vger.kernel.org>
- User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0
On 4/24/2012 1:12 PM, Russell King - ARM Linux wrote:
> If you don't have the clk API configured, you have no clocks to control.
> So, why not make clk_get() return NULL, and make the rest of the API
> calls do nothing? That's what you'll end up codifying in the drivers
> anyway.
Ok. We can return NULL from calls that return clk *. What about other
routines that return integers. Like, clk_enable().
Is returning 0 correct? Which would mean we were able to enable clk, but
actually we haven't.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Filesystems]
[Linux SCSI]
[Linux RAID]
[Git]
[Kernel Newbies]
[Linux Newbie]
[Share Photos]
[Security]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]