- To: Andrew Lunn <andrew@xxxxxxx>
- Subject: Re: [PATCH V2 4/9] ata/sata_mv: Remove conditional compilation of clk code
- From: Viresh Kumar <viresh.kumar@xxxxxx>
- Date: Tue, 24 Apr 2012 12:35:23 +0530
- Cc: "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linux@xxxxxxxxxxxxxxxx" <linux@xxxxxxxxxxxxxxxx>, "sshtylyov@xxxxxxxxxx" <sshtylyov@xxxxxxxxxx>, spear-devel <spear-devel@xxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-ide@xxxxxxxxxxxxxxx" <linux-ide@xxxxxxxxxxxxxxx>, "viresh.linux@xxxxxxxxx" <viresh.linux@xxxxxxxxx>, "mturquette@xxxxxxxxxx" <mturquette@xxxxxxxxxx>, "jgarzik@xxxxxxxxxx" <jgarzik@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
- In-reply-to: <20120424070426.GA24089@lunn.ch>
- List-id: <linux-ide.vger.kernel.org>
- User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0
On 4/24/2012 12:34 PM, Andrew Lunn wrote:
> I don't think this change is correct. With the old semantics, it was:
Sorry. :(
> If we have CLK support, we expect there to be a clock for sata_mv, and
> if there is no such clock, output a notice message, something is
> probably wrong, i expected there to be a clock.
>
> The new semantics are:
>
> We expect there to be a clock for sata_mv, and if there is no such
> clock, output a notice message, something is probably wrong, i
> expected there to be a clock.
>
> We are going to see this notice message much more, when it is not
> expected.
So, the only problem is this message?
How do you suggest to tackle this now. Have #ifdef,#endif around this print?
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux Filesystems]
[Linux SCSI]
[Linux RAID]
[Git]
[Kernel Newbies]
[Linux Newbie]
[Share Photos]
[Security]
[Netfilter]
[Bugtraq]
[Photo]
[Yosemite]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Samba]
[Video 4 Linux]
[Device Mapper]
[Linux Resources]