Re: [PATCH] libata: clear error mask of old error history

[Lin Ming <ming.m.lin@xxxxxxxxx>]

On Fri, Apr 20, 2012 at 6:29 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
>
> On 20-04-012 5:38, Lin Ming wrote:
>
>> The old error history was cleared in ata_ering_clear().
>> It only sets ATA_EFLAG_OLD_ER eflags, but the err_mask was not cleared.
>> So ata_ering_map() still iterates the old error history.
>
>
>> This causes problem, for example, wrong probe trials count were returned
>> in
>> ata_eh_schedule_probe(), which in turn causes SATA link speed to be slowed
>> down
>> to 1.5Gbps.
>
>
>> Reported-and-tested-by: Martin Mokrejs<mmokrejs@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Lin Ming<ming.m.lin@xxxxxxxxx>
>> ---
>
>
>> Hi Jeff,
>
>
>> This patch fixes an old regression introduced in 2.6.37-rc1
>> of commit d902747.
>
>
>> So it should be included into stable releases since 2.6.37.
>
>
>   You should have included:
>
> Cc: stable@xxxxxxxxxxxxxxx # 2.6.37+
>
> after your signoff in this case.

Re-send with stable CCed.

Thanks.

>
> MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html