RE: [PATCH v2 1/3] PATA host controller driver for ep93xx

[H Hartley Sweeten <hartleys@xxxxxxxxxxxxxxxxxxx>]

On Tuesday, April 03, 2012 1:08 PM, Arnd Bergmann wrote:
> On Tuesday 03 April 2012, H Hartley Sweeten wrote:
>> On Tuesday, April 03, 2012 7:45 AM, Rafal Prylowski wrote:
>>> +static int __devinit ep93xx_pata_probe(struct platform_device *pdev)
>>> +{
>>> +     struct ep93xx_pata_data *drv_data;
>>> +     struct ata_host *host;
>>> +     struct ata_port *ap;
>>> +     unsigned int irq;
>>> +     struct resource *mem_res;
>>> +     void __iomem *ide_base;
>>> +     int err;
>>> +
>>> +     err = ep93xx_ide_acquire_gpio(pdev);
>>> +     if (err)
>>> +             return err;
>
> Calling into platform code like this is going to make the transition to
> device tree harder. I would suggest moving the code from patch 2 here,
> and subsequently putting the gpio lines into device tree properties.
> when the driver gets converted.

The SYSCON stuff is not exposed outside of the arch specific mach-ep93xx
directory. I would prefer this stay like it is for now. If/when ep93xx gets
converted to device tree we can address this.

I have been looking over the drivers/pinctrl stuff to see if it's worth creating
a pinctrl-ep93xx.c driver. If I end up doing one, the function above could
probably be replaced with something from the pin mux api.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html