RE: [PATCH v2 28/28] libsas: don't recover 'gone' devices in sas_ata_hard_reset()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I pull the new V2 patchset, it works fine.
I found another bug in libsas, will send out later.

Jack

[PATCH v2 28/28] libsas: don't recover 'gone' devices in
> sas_ata_hard_reset()
> 
> The commands that timeout when a disk is forcibly removed may trigger
> libata to attempt recovery of the device.  If libsas has decided to
> remove the device don't permit ata to continue to issue resets to its
> last known phy.
> 
> The primary motivation for this patch is hotplug testing by writing 0 to
> /sys/class/sas_phy/phyX/enable.  Without this check this test leads to
> libata issuing a reset and re-enabling the device that wants to be torn
> down.
> 
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
>  drivers/scsi/libsas/sas_ata.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index 96f316f..2814731 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -321,6 +321,9 @@ static int sas_ata_hard_reset(struct ata_link *link,
> unsigned int *class,
>  	struct domain_device *dev = ap->private_data;
>  	struct sas_internal *i = dev_to_sas_internal(dev);
> 
> +	if (dev->gone)
> +		return -ENODEV;
> +
>  	res = i->dft->lldd_I_T_nexus_reset(dev);
> 
>  	if (res != TMF_RESP_FUNC_COMPLETE)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux