Re: [patch v3 1/3] block: add a non-queueable flush flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/04/2011 09:59 PM, shaohua.li@xxxxxxxxx wrote:
flush request isn't queueable in some drives. Add a flag to let driver
notify block layer about this. We can optimize flush performance with the
knowledge.

Signed-off-by: Shaohua Li<shaohua.li@xxxxxxxxx>
---
  block/blk-settings.c   |    6 ++++++
  include/linux/blkdev.h |    7 +++++++
  2 files changed, 13 insertions(+)

hmmm.

This assumes that flush on new hardware, by default, is queueable.

I think the sense should be reversed: don't enable the optimization, unless we know the optimization works.

That seems safer than always enabling the optimization, unless we know it does not work. That is not a fail-safe mode of operation.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux