Re: [regression] sata_mv: harddisk activity led no longer responsive on QNAP TS-109

[Frans Pop <elendil@xxxxxxxxx>]

On Tuesday 26 August 2008, Frans Pop wrote:
> After booting the system I did 'echo 1 >/sys/block/sdX/device/queue_depth'
> and after that the HDD led showed disk activity again.

And to confirm that, applying the following patch to sata_mv for 2.6.26.3
makes the HDD led work again as well:

--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -131,7 +131,7 @@ enum {

        MV_GENIIE_FLAGS         = MV_COMMON_FLAGS | MV_6XXX_FLAGS |
                                  ATA_FLAG_PMP | ATA_FLAG_ACPI_SATA |
-                                 ATA_FLAG_NCQ | ATA_FLAG_AN,
+                                 ATA_FLAG_AN,

        CRQB_FLAG_READ          = (1 << 0),
        CRQB_TAG_SHIFT          = 1,

So somehow enabling NCQ is at the root of the issue.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html