Re: [PATCHv3-resend] atomic: add *_dec_not_zero

[Arnd Bergmann <arnd@xxxxxxxx>]

On Friday 17 June 2011, Sven Eckelmann wrote:
> 
> Introduce an *_dec_not_zero operation.  Make this a special case of
> *_add_unless because batman-adv uses atomic_dec_not_zero in different
> places like re-broadcast queue or aggregation queue management. There
> are other non-final patches which may also want to use this macro.
> 
> Reported-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx>
> Acked-by: Mike Frysinger <vapier@xxxxxxxxxx>
> Acked-by: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
> Acked-by: Ingo Molnar <mingo@xxxxxxx>
> Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Acked-by: David Howells <dhowells@xxxxxxxxxx>
> Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Acked-by: Will Deacon <will.deacon@xxxxxxx>
> Acked-by: Matt Turner <mattst88@xxxxxxxxx>
> Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx>
> Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Acked-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Cc: linux-ia64@xxxxxxxxxxxxxxx
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx
> ---
> Nothing changed - only added the Acked-by from Hirokazu Takata. That
> means that I am still waiting for ia64 and Arnd Bergmann (maybe he wants
> to merge it in his tree?).

Hmm, I didn't look at the first versions unfortunately. Remind me why we don't just
open-code the atomic_add_unless in batman-adv.

Since people apparently think that this patch is a good idea, I'll merge it in
the asm-generic tree once I understand why this is done.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html