Re: [patch 1/4] syscall.h support for ia64

[Roland McGrath <roland@xxxxxxxxxx>]

Is it really right not to handle the IS_IA32_PROCESS cases at all?
It looked me like it would be easy to handle those.

syscall_get_nr needs to return -1L when the task is not in a syscall.

This line concerns me:

+		count = min_t(int, args->n, cfm & 0x7f);

I take this to mean that you can tell how many arguments might be
accessible.  If fewer than 6 are available, you leave args[count..5]
uninitialized.  You should set them to something (e.g. 0 or -1),
or else this is an information leak of random kernel stack words.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html