Re: [patch v3 24/36] Hexagon: Provide basic implementation and/or stubs for I/O routines.
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
On Friday 09 September 2011 14:14:13 Linas Vepstas wrote: > On Thu, Sep 08, 2011 at 08:09:11PM -0500, Richard Kuo wrote: > > + asm volatile( > > + "memb(%0) = %1;" > > + : > > + : "r" (addr), "r" (data) > > + ); > > I'm kind-of vague on this, but I think that this also needs a > : "memory" at the end (to indicate that the asm snippet clobbers > memory), as otherwise the compiler may be tempted to reorder > these around other memory accesses. That is, the "volatile" > keyword is not enough (well, I'm not sure...), but I think > "volatile" only prevents the compiler from optimizing these > away completely, but is not enough to prevent unwanted > re-ordering. Yes, absolutely correct. Specifically, this is required for the case where you first store values into regular memory and then use the writel() to trigger a DMA operation. Without the memory clobber, the dma may read from memory before the CPU has accessed it in case the store gets scheduled after the writel by the compiler. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html