Google
  Web www.spinics.net

[PATCH] Masking bug in 6pack driver?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Looks like a broken masking to me, binary not is used where bitwise not
was intended.

Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
---
 drivers/net/hamradio/6pack.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.19-rc6.orig/drivers/net/hamradio/6pack.c	2006-09-21 21:27:38.000000000 +0200
+++ linux-2.6.19-rc6/drivers/net/hamradio/6pack.c	2006-11-23 18:46:37.000000000 +0100
@@ -914,7 +914,7 @@
 					printk(KERN_DEBUG "6pack: protocol violation\n");
 				else
 					sp->status = 0;
-				cmd &= !SIXP_RX_DCD_MASK;
+				cmd &= ~SIXP_RX_DCD_MASK;
 		}
 		sp->status = cmd & SIXP_PRIO_DATA_MASK;
 	} else { /* output watchdog char if idle */


-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Site Home]     [Linux Newbie]     [Kernel Newbies]     [Memory]     [Security]     [Netfilter]     [Linux Admin]     [Bugtraq]     [Rubini]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [ARM Linux Kernel]     [Linux Networking]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linux Resources]


Add to Google Powered by Linux