Re: [RFC] odd thing in btrfs_file_aio_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oh, that's my fault, I forgot that iov can be chained.

I should use 'pos + count' instead.

Thanks for pointing it out.
Qu.

-------- Original Message --------
Subject: [RFC] odd thing in btrfs_file_aio_write()
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
To: Chris Mason <clm@xxxxxx>
Date: 2014年04月14日 08:26
		end_pos = round_up(pos + iov->iov_len, root->sectorsize);

added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf
Author: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
Date:   Thu Mar 27 02:51:58 2014 +0000

     btrfs: Change the expanding write sequence to fix snapshot related bug.

doesn't look right - after all, just split the first iovec in the array
and end_pos will go down.  Do we want pos + count instead of
pos + iov->iov_len there?

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux