Re: [PATCH V3] block: Mitigate lock unbalance caused by lock switching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/30/2012 02:28 PM, Tejun Heo wrote:
Hello,

On Wed, May 30, 2012 at 3:28 PM, Asias He<asias@xxxxxxxxxx>  wrote:
Isn't the 'if' clause superfluous ? You could just do the assignment,
e.g.,

+       spin_lock_irq(lock);
+       q->queue_lock =&q->__queue_lock;
+       spin_unlock_irq(lock);


Well, this saves a if clause but adds an unnecessary assignment if the lock
is already internal lock.

It's not hot path. Dirtying the cacheline there doesn't mean anything.
I don't really care either way but making optimization argument is
pretty silly here.

I don't care this neither ;-)

--
Asias
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux