Re: [PATCH 1/1] ext4, dio: Remove overflow for size >2G in aio-dio code.

[Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>]

On Sun, May 20, 2012 at 1:01 AM, manish honap
<manish_honap_vit@xxxxxxxxxxx> wrote:
>
> From: Manish Honap <manish_honap_vit@xxxxxxxxxxx>
>
> The direct-io.c::do_direct_io() returns int and  this causes the results to
> overflow for sizes>=2g; the following patch removes this bug.
>
> Signed-off-by: Manish Honap <manish_honap_vit@xxxxxxxxxxx>

It should not be possible to do a write bigger than 2GB - the generic
VFS layer should stop it. Exactly because of overflow avoidance issues
(and because a single 2GB+ write would be insane and has serious DoS
issues anyway).

Can you actually *trigger* this issue some way? If so, we should fix
that instead.

                            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html