Re: /proc/pid/fd/ shows strange mode when executed via sudo.

[Al Viro <viro@xxxxxxxxxxxxxxxxxx>]

> I would suggest just moving the i_mode initialization from
> proc_fd_instantiate() into the revalidate function that we already
> have, and that already fixes up i_uid/i_gid etc. Attached is a TOTALLY
> UNTESTED patch that does this, and actually seems to simplify things
> in the process.

I think this is bogus.  We don't give a fuck about *any* of those fields
for symlinks; the only problem here is that default ->getattr() uses
them to fill ->st_mode et.al.  The same goes for ->i_uid/->i_gid.
So how about simply adding ->getattr() for those guys?  And to hell
with assignments in that ->d_revalidate() instance...
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html