Re: osd_req_encode_op() breakage?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Apr 18, 2012 at 8:32 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Apr 18, 2012 at 10:09:05AM -0500, Alex Elder wrote:
>
> > Yes, you are absolutely correct.
> >
> > We have obviously not done endianness checks in this code for
> > some time.
> >
> > I will commit a fix and credit you for it.  I'll also make sure
> > we are doing proper testing for this sort of thing on a regular
> > basis.
>
> FWIW, that got caught by sparse, but I would really recommend _testing_
> on big-endian - getting an emulated headless e.g. mips box is fairly
> easy with qemu; I'd done that with debian big-endian mips userland on
> emulated malta and it didn't take much work to set up.
>
> Speaking of sparse, I think we simply ought to add -D__CHECK_ENDIAN__
> to CHECKFLAGS in top-level Makefile.  It's not _that_ much noise
> these days...  Not sure which tree should that go through, though...

Definitely. I've run sparse on that code from time to time, but
completely forgot about this flag and assumed everything was ok.

Yehuda
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Ext4 Filesystem]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [CEPH Filesystem]


  Powered by Linux