Re: [PATCH] fs: make i_generation a u64

[Marco Stornelli <marco.stornelli@xxxxxxxxx>]

2012/4/11 Josef Bacik <josef@xxxxxxxxxx>:
> Btrfs stores generation numbers as 64bit numbers, which means we have to
> carry around a u64 in our incore inode in addition to setting i_generation.
> So convert to a u64 so btrfs can kill it's incore generation.  Thanks,
>
> Signed-off-by: Josef Bacik <josef@xxxxxxxxxx>
> ---
>  include/linux/fs.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 9be896d..40564e0 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -831,7 +831,7 @@ struct inode {
>                struct cdev             *i_cdev;
>        };
>
> -       __u32                   i_generation;
> +       u64                     i_generation;
>
>  #ifdef CONFIG_FSNOTIFY
>        __u32                   i_fsnotify_mask; /* all events this inode cares about */
> --
> 1.7.7.6

This patch can have several impact on other fs. Only to do an example
you can see the code in ioctl of ext4. I haven't got study the code
but the ioctl returns a long, but on 32bit system, long means 4 bytes,
so how we can return i_generation with ioctl?

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html