Re: [PATCH] net, bridge: print log message after state changed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: <bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] net, bridge: print log message after state changed
From: "Valerio Granato" <contact@xxxxxxxxxx>
Date: Thu, 17 Nov 2011 07:19:16 +0100
Delivered-to: bridge@xxxxxxxxxxxxxxxxxxxxxxxx
References: <1320941934-3534-1-git-send-email-holger.brunck@keymile.com><20111114.003702.1097206603722725705.davem@davemloft.net><1321254211.4072.29.camel@pc005091.de.keymile.net> <20111114.020749.1176229013272872343.davem@davemloft.net>

---- Original Message ----
From: "David Miller" <davem@xxxxxxxxxxxxx>
To: <Wolfgang.Fritz@xxxxxxxxxxx>
Cc: <netdev@xxxxxxxxxxxxxxx>; <shemminger@xxxxxxxxxxxxxxxxxxxx>;
<bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx>; <holger.brunck@xxxxxxxxxxx> Sent:
Monday, November 14, 2011 8:07 AM Subject: Re:  [PATCH]

net,bridge: print log message after state changed

I would never expect an "entering" message to print out after the
event happens, and in fact I'd _always_ want to see it beforehand so
that if the state change caused a crash or similar it'd be that much
easier to pinpoint the proper location.


I think this is a really good point of view.
I agree.

Valerio
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/bridge

References:
- [PATCH] net, bridge: print log message after state changed
  - From: Holger Brunck
- Re: [PATCH] net, bridge: print log message after state changed
  - From: David Miller
- Re: [PATCH] net, bridge: print log message after state changed
  - From: Fritz, Wolfgang
- Re: [PATCH] net, bridge: print log message after state changed
  - From: David Miller

Prev by Date: Problems with stateful firewall and bridge
Next by Date: Re: [PATCH] net, bridge: print log message after state changed
Previous by thread: Re: [PATCH] net, bridge: print log message after state changed
Next by thread: Re: [PATCH] net, bridge: print log message after state changed
Index(es):
- Date
- Thread

[Netdev] [AoE Tools] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Photo] [Yosemite] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba] [Video 4 Linux] [Linux Resources]