Re: possible bridge regression in "bridge: implement [add/del]_slave ops"?

["Weirich, Bernhard" <Bernhard.Weirich@xxxxxxxxxx>]

Hello,

I had trouble with the new detection code for interface ports. 
In turned out that the carrier was down, but IFF_RUNNING was set. 
I changed the code to check for IFF_UP & IFF_LOWER_UP for interface ports and now it works the way it should.
Would it be better to check IFF_LOWER_UP or is my interface device driver incorrect?

Best regards,
Bernhard


----------------------------------------------------------------------

From: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
Subject: Re:  possible bridge regression in "bridge: implement
        [add/del]_slave ops"?
To: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx, bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx,  "David
        S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Message-ID: <20110705142858.3b7e5941@xxxxxxxxxxxxxxxxxxxxxxx>
Content-Type: text/plain; charset=US-ASCII

I just put a fix for the detection of bridge pseudo-device being up
into the current rstp code available at:
  git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/rstp.git


------------------------------

_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge

End of Bridge Digest, Vol 95, Issue 3
*************************************
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge