Re: [PATCH] net: bridge: check the length of skb after nf_bridge_maybe_copy_header()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

From: Changli Gao <xiaosuo@xxxxxxxxx>
Date: Sat, 25 Dec 2010 21:41:30 +0800

> Since nf_bridge_maybe_copy_header() may change the length of skb,
> we should check the length of skb after it to handle the ppoe skbs.
> Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx>

This is really strange.

packet_length() subtracts VLAN_HLEN from the value it returns, so the
correct fix seems to be to make this function handle the PPPOE case

Otherwise I suspect you have many other functions to fix as well.

I'm not applying this patch.
Bridge mailing list

[Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]     [Linux Resources]

Add to Google Powered by Linux