Re: [PATCH] net: bridge: check the length of skb after nf_bridge_maybe_copy_header()

[David Miller <davem@xxxxxxxxxxxxx>]

From: Changli Gao <xiaosuo@xxxxxxxxx>
Date: Sat, 25 Dec 2010 21:41:30 +0800

> Since nf_bridge_maybe_copy_header() may change the length of skb,
> we should check the length of skb after it to handle the ppoe skbs.
> 
> Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx>

This is really strange.

packet_length() subtracts VLAN_HLEN from the value it returns, so the
correct fix seems to be to make this function handle the PPPOE case
too.

Otherwise I suspect you have many other functions to fix as well.

I'm not applying this patch.
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge