Re: [PATCH 4/4] module: Use the binary search for symbols resolution

[Wanlong Gao <wanlong.gao@xxxxxxxxx>]

 2011-4-19 19:35, Rusty Russell wroted:
> On Tue, 19 Apr 2011 09:44:20 +0800, Wanlong Gao<wanlong.gao@xxxxxxxxx>  wrote:
> >    2011-4-19 9:37, Rusty Russell wroted:
> > > On Sat, 16 Apr 2011 22:32:08 +0800, Wanlong Gao<wanlong.gao@xxxxxxxxx>   wrote:
> > > > > +	sym = bsearch(fsa->name, syms->start, syms->stop - syms->start,
> > > > As the bsearch func, why not change the syms->stop to syms->end ?
> > > > Hmm..Just a stupid suggestion.
> > >
> > >
> > > The names are derived from the linker symbols for end of sections, which
> > > is __stop_<sectionname>.
> > >
> > > Cheers,
> > > Rusty.
> > As this , why not change the bsearch's "end" to "stop", too ? It will be
> > more readable.
>
> I'm confused.  bsearch uses a count, not an end pointer...
>
> Rusty.

Hmm...I see, I see . I made a mistake on this func .
Thanks for your explanation.

Best regards
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html