Re: [RFC][PATCH] KBUS messaging subsystem

[Sam Ravnborg <sam@xxxxxxxxxxxx>]

[Edited cc: list as my smtp server refused to send the original reply]
> 
> Our tentative patch is at
> http://kbus.googlecode.com/files/0001-KBUS-messaging-subsystem.patch
> 
> The diffstat for the patch is:
> 
>  Documentation/Kbus.txt     | 1189 ++++++++++
>  include/linux/kbus_defns.h |  666 ++++++
>  init/Kconfig               |    3 +
>  ipc/Kconfig                |   99 +
>  ipc/Makefile               |    1 +
>  ipc/kbus.c                 | 5120 ++++++++++++++++++++++++++++++++++++++++++++
>  ipc/kbus_internal.h        |  773 +++++++
>  7 files changed, 7851 insertions(+), 0 deletions(-)
> 
> Should I just submit the patch to this list?

You will get more feedback on lkml...
Looks like comprehensive descriptions - good!

Took a quick peek at the patch.

- use __u32 (and friends) in exported headers - not uint32_t.
- do not invent our own logging system. Use one of the standard methods.

If you post for review try to divide it up a little.
Maybe kbus.c in one patch, Makefile + Kconfig in last patch.
It is a large file to review already.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html