Google
  Web www.spinics.net

Patch: usbvision: Convert the usbvision->lock semaphore to the mutex API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Looking at this patch.  I have a couple of stupid questions.
 
- up(&usbvision->lock);
+ mutex_unlock(&usbvision->lock);
 
+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
+#include <linux/mutex.h>
+#endif
#include <media/v4l2-common.h>
#include <media/tuner.h>
#include <linux/videodev2.h>
@@ -397,7 +400,11 @@ struct usb_usbvision {
unsigned char iface; /* Video interface number */
unsigned char ifaceAlt; /* Alt settings */
unsigned char Vin_Reg2_Preset;
- struct semaphore lock;
+#if LINUX_VERSION_CODE > KERNEL_VERSION(2,6,15)
+ struct mutex               lock;
+#else
+ struct semaphore           lock;
+#endif
Do we really need to check the kernel version?   We just removed all the old susbvision->lock semaphores to the mutex API

 

Dwaine


_______________________________________________
linux-dvb users mailing list
For V4L/DVB development, please use instead linux-media@xxxxxxxxxxxxxxx
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Linux Media]     [Video 4 Linux]     [Video Technology]     [Asterisk]     [Photo]     [Samba]     [Xorg]     [Xfree86]     [Devices]     [DVB Maintainer]     [Linux USB]