Re: [PATCH] staging: goldfish: switch from spinlock to mutex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 03, 2014 at 01:00:53PM +0300, Kristina Martšenko wrote:
> On 03/04/14 11:32, Dan Carpenter wrote:
> > Sorry for the delay, I'm just catching up with some old emails.
> 
> No problem.
> 
> > On Tue, Mar 25, 2014 at 01:45:09AM +0200, Kristina Martšenko wrote:
> >> Use a mutex instead of a spinlock in goldfish_nand.c, as suggested by
> >> the TODO list.
> >>
> >> Signed-off-by: Kristina Martšenko <kristina.martsenko@xxxxxxxxx>
> > 
> > Have you tested this change?
> 
> Nope, just compile-tested. After a day of trying to get the emulator to
> work I finally gave up and decided that it looked okay enough... I
> should have mentioned under the patch description that it wasn't tested,
> sorry.

It's not a wrong thing to submit patches that you can't test, but in
this case the irq save/restores make me nervous.  I can't see that they
served any purpose and it's certainly not unheard of for staging code to
do pointless things for unexplainable reasons.  But on the other hand, I
would feel a lot more comfortable if this change were tested or if there
were more comments about how the change is safe.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel





[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux