Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



When checking buffers.c with checkpatch.pl it throws the following error: drivers/staging/speakup/buffers.c:58: ERROR: return is not a function, parentheses are not required

I watched one of your talks, it's very informative and concise: http://www.youtube.com/watch?v=LLBrBBImJt4&feature=youtu.be

Thanks,
Reza Snowdon

On 27/02/14 16:40, Greg KH wrote:
On Thu, Feb 27, 2014 at 04:26:42PM +0000, Reza Snowdon wrote:
Fixed a coding style issue.

Signed-off-by: Reza Snowdon <rs@xxxxxxxxxx>
---
  drivers/staging/speakup/buffers.c |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c
index 382973e..8d7caa7 100644
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -55,7 +55,8 @@ static int synth_buffer_free(void)

  int synth_buffer_empty(void)
  {
-	return (buff_in == buff_out);
+	int buff_comparison = (buff_in == buff_out);
+	return buff_comparison;

What's wrong with the original code here?  If anything, just drop the
(), but really, it's fine, leave it alone, it's obvious what is
happening is ok.

thanks,

greg k-h



--
Regards,
Reza Snowdon
>From a2dda399463c20f63306e31b743e0c9c3be2ca3a Mon Sep 17 00:00:00 2001
From: Reza Snowdon <rs@xxxxxxxxxx>
Date: Thu, 27 Feb 2014 17:57:59 +0000
Subject: [PATCH] Staging: speakup: buffers: Fixed a return coding style issue

When checking buffers.c with checkpatch.pl it throws the following error: drivers/staging/speakup/buffers.c:58: ERROR: return is not a function, parentheses are not required

Fixed error by removing parenthesis.

Signed-off-by: Reza Snowdon <rs@xxxxxxxxxx>
---
 drivers/staging/speakup/buffers.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c
index 382973e..5e6ec13 100644
--- a/drivers/staging/speakup/buffers.c
+++ b/drivers/staging/speakup/buffers.c
@@ -55,7 +55,7 @@ static int synth_buffer_free(void)
 
 int synth_buffer_empty(void)
 {
-	return (buff_in == buff_out);
+	return buff_in == buff_out;
 }
 EXPORT_SYMBOL_GPL(synth_buffer_empty);
 
-- 
1.7.10.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux