Re: [PATCH v3 3/7] staging: dgnc: removes casting around kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 12, 2013 at 6:00 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Sep 09, 2013 at 03:01:24PM -0400, Lidza Louina wrote:
>> This patch removes casting around kzalloc calls.
>> The casts aren't needed because kzalloc returns
>> a void pointer.
>>
>> Signed-off-by: Lidza Louina <lidza.louina@xxxxxxxxx>
>> ---
>>  drivers/staging/dgnc/dgnc_driver.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
>> index 89c332f..3717d86 100644
>> --- a/drivers/staging/dgnc/dgnc_driver.c
>> +++ b/drivers/staging/dgnc/dgnc_driver.c
>> @@ -499,7 +499,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id)
>>
>>       /* get the board structure and prep it */
>>       brd = dgnc_Board[dgnc_NumBoards] =
>> -     (struct dgnc_board *) kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
>> +     kzalloc(sizeof(struct dgnc_board), GFP_KERNEL);
>
> Very odd indentation, this should be:
>         brd = dgnc_Board[dgnc_NumBoards] = kzalloc(sizeof(struct dgnc_board),
>                                                    GFP_KERNEL);
>
> right?
>
> I've gotten patches from 2 others for this same type of fix, it seems
> people are going through the whole tree for this issue at the moment.

Okay, that's really awesome. :)
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux