Re: [PATCH v2 1/4] [media] lirc_bt829: Fix physical address type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 4, 2013 at 11:31 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> Use phys_addr_t and log format %pa.
>
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> ---
>  drivers/staging/media/lirc/lirc_bt829.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc/lirc_bt829.c
> index fa31ee7..9c7be55 100644
> --- a/drivers/staging/media/lirc/lirc_bt829.c
> +++ b/drivers/staging/media/lirc/lirc_bt829.c
> @@ -63,7 +63,7 @@ static bool debug;
>         } while (0)
>
>  static int atir_minor;
> -static unsigned long pci_addr_phys;
> +static phys_addr_t pci_addr_phys;
>  static unsigned char *pci_addr_lin;
>
>  static struct lirc_driver atir_driver;
> @@ -78,8 +78,7 @@ static struct pci_dev *do_pci_probe(void)
>                 pci_addr_phys = 0;
>                 if (my_dev->resource[0].flags & IORESOURCE_MEM) {
>                         pci_addr_phys = my_dev->resource[0].start;
> -                       pr_info("memory at 0x%08X\n",
> -                              (unsigned int)pci_addr_phys);
> +                       pr_info("memory at %pa\n", &pci_addr_phys);

Looks much better :-)

Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux