Re: [PATCH 1/6] staging: nvec: convert to devm_ functions

[Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Wed, Jun 13, 2012 at 11:16:29AM +0200, Marc Dietrich wrote:
> This patch cleanups the nvec and its childs by replacing calls to
> resource allocations by their devm_* equivalents.
> 
> Signed-off-by: Marc Dietrich <marvin24@xxxxxx>
> ---
> 
> fixed line wrap.
> 
> 
>  drivers/staging/nvec/nvec.c       |   46 +++++++++++++------------------------
>  drivers/staging/nvec/nvec_leds.c  |   10 +++-----
>  drivers/staging/nvec/nvec_power.c |    8 ++++---
>  drivers/staging/nvec/nvec_ps2.c   |    6 ++++-
>  4 files changed, 29 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> index 3c60088..b18cbde 100644
> --- a/drivers/staging/nvec/nvec.c
> +++ b/drivers/staging/nvec/nvec.c
> @@ -132,7 +132,7 @@ static int nvec_status_notifier(struct notifier_block *nb,
>  	if (event_type != NVEC_CNTL)
>  		return NOTIFY_DONE;
>  
> -	printk(KERN_WARNING "unhandled msg type %ld\n", event_type);
> +	pr_warn("unhandled msg type %ld\n", event_type);

That doesn't look like a devm change :(

Please, do only one thing per patch, care to redo this please?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel