Re: [PATCH 2/6] staging/xgifb: move mtrr variable under CONFIG_MTRR

[Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>]

On Mon, Mar 19, 2012 at 09:50:10PM +0400, Dmitry Eremin-Solenikov wrote:
> There is no need for mtrr value or any code around it if the kernel is
> built w/o CONFIG_MTRR. For code cleanup move data member under
> CONFIG_MTRR ifdef.

That's not a valid "code cleanup".  We don't like #ifdefs in .c files,
and as this does not cause any problems as-is, it should be left alone.

So, sorry, I'm not going to accept this patch.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel