Re: [PATCH] staging: comedi: usbdux: remove an unnecessary dev_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Apr 02, 2012 at 12:00:59PM +0100, Ian Abbott wrote:
> usbdux_attach_common() prints two messages via dev_info() that shows a
> device has been attached.  The first of these messages includes an index
> into a static array that the function determines by pointer subtraction,
> assuming the pointer passed to the function points to an element of the
> array.  Dan Carpenter pointed out that this was kind of ugly.  Since the
> dev_info() that prints the array index doesn't add anything useful
> (since no other messages print the array index and nothing else uses
> it), let's just get rid of it.
> 

Great.  Thanks for doing that.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux