Re: [PATCH] staging: comedi: usbdux: remove an unnecessary dev_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, Apr 02, 2012 at 12:00:59PM +0100, Ian Abbott wrote:
> usbdux_attach_common() prints two messages via dev_info() that shows a
> device has been attached.  The first of these messages includes an index
> into a static array that the function determines by pointer subtraction,
> assuming the pointer passed to the function points to an element of the
> array.  Dan Carpenter pointed out that this was kind of ugly.  Since the
> dev_info() that prints the array index doesn't add anything useful
> (since no other messages print the array index and nothing else uses
> it), let's just get rid of it.

Great.  Thanks for doing that.

dan carpenter
devel mailing list

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [X.Org]     [Yosemite Backpacking]

  Powered by Linux