Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Feb 20, 2012 at 11:47:28AM -0300, Ezequiel García wrote:
> > 2012/2/18 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> >>
> >> If I send more patches about easycap driver, can I base it on my
> >> current local branch?
> >> I mean, based on all these patches?
> >>
> >
> > Yeah.  I don't really mind.  If you want to fix these in a later
> > patch that's ok by me.  I just wanted to explain how multi-line
> > comments are supposed to look so you get it right in later patches.
> >
> 
> I'll resend the patch as v2.
> 
> What I meant to ask was: I want to keep working on this driver, doing
> more fixes.
> Can I send patches based on the previous ones?

Yeah.

So how it works is that Mauro (who is not CC'd) pulls patches from
the list.  Mauro maintains everything in drivers/staging/media/.
If he likes the patches he merges them.  Generally they get merged
in the order they were submitted.

If there are twenty patches randomly sent to the list, then there is
more and more chance that one of them will get dropped for some
reason and all the later patches will have to be redone.  So it's
sometimes better to send the patches in batches of 10 or so instead
of sending ten patches in a random order over several days.  Huge
patchsets are a pain to review though and sometimes people modify
stuff you are working on so you have to redo the whole patchset.  So
don't make the patchset too large.

Sometimes a patch will get rejected or merged out of order and you
have to redo everything.

Also Tomas Winkler has been working on this driver so you'd have to
coordinate with him as well.  If he sends a patch, then your patch
has to apply on top of his.  CC him on any patches you send for
easycap.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux