Re: [PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sun, Feb 19, 2012 at 08:00:27PM -0300, Ezequiel García wrote:
> Hi,
> 
> El día 19 de febrero de 2012 17:49, Dan Carpenter
> <dan.carpenter@xxxxxxxxxx> escribió:
> >
> > You've dropped Greg and driver devel from the CC list.  It's all up
> > to Greg whether to merge your patch or not, so it doesn't matter
> > what I say if he isn't on the CC list.
> 
> Sorry for that. I've just forwarded my previous mail to driver devel list.
> 
> >
> > None of the multi-line commits were totally right according to
> > CodingStyle so it's probably best to just redo the patch and send
> > a v2.
> 
> What do you mean with "not totally right".
> Just point out what's wrong and I'll be glad to fix it :)
> 

The preferred style for long (multi-line) comments is:

        /*
         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         *
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.
         */

From CodingStyle.

regards,
dan carpenter

Attachment: signature.asc
Description: Digital signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

[Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Free Singles Community]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux